Grouped Kibana nav #53545

myasonik · 2019-12-19T00:40:59Z

Summary

Closes #53313

Dev docs

Plugins should now define a category if they have a navigation item:

If you want to fit into our default categories, you can use our DEFAULT_APP_CATEGORIES defined in src/core/utils/default_app_categories.ts.
If you want to create their own category, you can also provide any object matching the AppCategory interface defined in src/core/types/app_category.ts.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-12-20T23:38:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8a82938

History

💔 Build #16830 failed c187078
💔 Build #16588 failed 1fb0a08c177a657f1f4bfaa43f4b5e44bc14bad6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

snide · 2020-01-07T23:05:29Z

Hey @myasonik I think this project is still on for 7.6. Running through the branch I think we'll likely need to make the following changes:

Looks like the SIEM link breaks.
Don't see an advanced setting to disable the grouping
The recently viewed items are not showing the icons from their app, but showing letters
~~We'll need to make it so any clicks in the sub menus close the sub-nav immediately. Right now the menu sticks around and then you need to click again to hide the menu~~ Handled by EuiNavDrawer focus management, flyout auto-close eui#2749

Icons are still on the way as are some small accessibility fixes from @thompsongl

myasonik · 2020-01-08T05:16:43Z

We'll need to make it so any clicks in the sub menus close the sub-nav immediately. Right now the menu sticks around and then you need to click again to hide the menu

@snide Do you want this to happen in Kibana or in EUI? I think we could do it in either place... If we want this to always to be the case then I'd err towards doing this in EUI but if it's something special for Kibana we can do it on this side.

thompsongl · 2020-01-08T22:47:51Z

@myasonik @snide Closing the flyout on click seems like something we could default to with EUI. I can't really think of a scenario where keeping it open is desirable.

snide · 2020-01-08T23:53:43Z

Agree with @thompsongl. Let's handle it there.

snide · 2020-01-10T18:57:13Z

Just as an update for anyone tracking. elastic/eui#2749 will fix the not closing problems. I checked to make sure that features controls change the logic of how this stuff appears as written in the spec issue.

Along with the remaining items from #53545 (comment) I added the advanced setting control, which might just be poorly labeled and I can't find it.

Icons are still coming and possibly would need to merge into EUI post feature freeze. I don't think the icons alone should block merging this PR though if product is still OK with the functionality.

myasonik · 2020-01-10T23:04:45Z

An update on the current state:

Should be "feature complete" 🎉
The OSS license check is hacky 🐉
The advanced setting check is hacky 🐲
There are no added tests 😨
There are broken tests (some I was able to "fix" by forcing the old nav using the advanced setting but not others) 🔴
This probably needs docs still for the API changes and the advanced settings 📖
The nav is broken when using the grouped nav but it will magically start working once EUI is updated so if it looks grouped, just trust it works for like a day or two...

src/core/public/application/types.ts

src/core/public/application/index.ts

src/core/public/chrome/chrome_service.tsx

src/core/public/chrome/ui/header/header.tsx

src/core/public/injected_metadata/injected_metadata_service.ts

src/core/public/legacy/legacy_service.ts

src/legacy/core_plugins/kibana/index.js

src/core/public/chrome/ui/header/header.tsx

lizozom

@elastic/kibana-app-arch changes LGTM

Kerry350

Infra changes LGTM 👍

myasonik · 2020-01-16T21:46:20Z

@elastic/kibana-platform Would love a re-review on header.tsx and header/header_bits/*.

Just did a bit of a refactor to encapsulate pieces better. Mostly didn't touch logic.

#1 goal was to make thinking about testing easier.

All of the those changes are in 06a2663.

pgayvallet

Re-review as of #53545 (comment)

Extracting the header components is great. Thank for the cleanup.

Just a remark about the folder structure

src/core/public/chrome/ui/header/header.tsx

src/core/public/chrome/ui/header/header_bits/index.tsx

myasonik · 2020-01-18T05:26:39Z

🚨 Merging first thing Tuesday morning unless someone finds a reason not to before then

myasonik · 2020-01-21T16:21:04Z

@elasticmachine merge upstream

gchaps · 2020-01-21T16:54:09Z

UI copy in welcome screen LGTM.

kibanamachine · 2020-01-21T17:39:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9a16416

History

💚 Build #21240 succeeded fe9f10d
💔 Build #21226 failed 181d384
💔 Build #20958 failed 7cd30ee
💔 Build #20661 failed 3d80243
💔 Build #20389 failed f8564f8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Adds concept of `category` to nav links, grouping them by this in the side nav

myasonik requested a review from joshdover December 19, 2019 00:41

rendering something semi-functional

c187078

myasonik force-pushed the kibana-grouped-nav branch from 1fb0a08 to c187078 Compare December 20, 2019 00:00

Michail Yasonik added 3 commits December 20, 2019 14:27

improving nested nav support

c8bbcee

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

fe54ec9

adding categories for more apps

8a82938

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

897e11b

thompsongl mentioned this pull request Jan 9, 2020

EuiNavDrawer focus management, flyout auto-close elastic/eui#2749

Merged

3 tasks

Michail Yasonik added 5 commits January 10, 2020 14:10

aligning on category enum

05e5b5d

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

0eb1a91

added advanced settings

f425dbc

add license check

3234902

forcing tests to run with individual nav items

5f04ed5

myasonik marked this pull request as ready for review January 10, 2020 23:00

myasonik requested a review from a team as a code owner January 10, 2020 23:00

myasonik requested a review from a team January 10, 2020 23:00

myasonik requested review from a team as code owners January 10, 2020 23:00

pgayvallet reviewed Jan 12, 2020

View reviewed changes

myasonik added the v7.6.0 label Jan 12, 2020

myasonik added v7.7.0 and removed v7.6.0 labels Jan 14, 2020

Michail Yasonik added 2 commits January 14, 2020 18:21

PR feedback and first attempt at renaming management -> stack management

e542a03

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

f8564f8

myasonik requested a review from a team as a code owner January 14, 2020 23:22

lizozom approved these changes Jan 15, 2020

View reviewed changes

Michail Yasonik added 2 commits January 15, 2020 13:34

fixing tests

3d80243

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

6bc77cf

Kerry350 approved these changes Jan 15, 2020

View reviewed changes

Michail Yasonik added 2 commits January 16, 2020 15:01

refactoring header component to prep for writing tests

06a2663

i18n fix

7cd30ee

pgayvallet reviewed Jan 17, 2020

View reviewed changes

src/core/public/chrome/ui/header/header.tsx Outdated Show resolved Hide resolved

src/core/public/chrome/ui/header/header_bits/index.tsx Outdated Show resolved Hide resolved

Michail Yasonik added 3 commits January 17, 2020 18:40

adding tests to header component

3110e0a

Merge remote-tracking branch 'upstream/master' into kibana-grouped-nav

181d384

fixing type error

fe9f10d

Merge branch 'master' into kibana-grouped-nav

9a16416

myasonik merged commit da54657 into elastic:master Jan 21, 2020

myasonik deleted the kibana-grouped-nav branch January 21, 2020 17:48

myasonik mentioned this pull request Jan 22, 2020

[7.x] Grouped Kibana nav (#53545) #55496

Merged

myasonik pushed a commit that referenced this pull request Jan 22, 2020

[7.x] Grouped Kibana nav (#53545) (#55496)

12f0c95

Adds concept of `category` to nav links, grouping them by this in the side nav

Kerry350 added a commit to Kerry350/kibana that referenced this pull request Jan 22, 2020

Port over Observability "category" changes from elastic#53545

fbed5ec

ryankeairns mentioned this pull request Jan 22, 2020

[Discuss] Kibana grouped navigation feedback #55609

Closed

myasonik mentioned this pull request Feb 18, 2020

Reverting grouped nav UI #57724

Merged

1 task

This was referenced Feb 28, 2020

Grouped Space Management features #54793

Closed

Grouped Role Management features #54794

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grouped Kibana nav #53545

Grouped Kibana nav #53545

myasonik commented Dec 19, 2019 •

edited

Loading

elasticmachine commented Dec 20, 2019

snide commented Jan 7, 2020 •

edited by myasonik

Loading

myasonik commented Jan 8, 2020 •

edited

Loading

thompsongl commented Jan 8, 2020

snide commented Jan 8, 2020

snide commented Jan 10, 2020

myasonik commented Jan 10, 2020

lizozom left a comment

Kerry350 left a comment

myasonik commented Jan 16, 2020 •

edited

Loading

pgayvallet left a comment

myasonik commented Jan 18, 2020

myasonik commented Jan 21, 2020

gchaps commented Jan 21, 2020

kibanamachine commented Jan 21, 2020

Grouped Kibana nav #53545

Grouped Kibana nav #53545

Conversation

myasonik commented Dec 19, 2019 • edited Loading

Summary

Dev docs

Checklist

For maintainers

elasticmachine commented Dec 20, 2019

💔 Build Failed

History

snide commented Jan 7, 2020 • edited by myasonik Loading

myasonik commented Jan 8, 2020 • edited Loading

thompsongl commented Jan 8, 2020

snide commented Jan 8, 2020

snide commented Jan 10, 2020

myasonik commented Jan 10, 2020

lizozom left a comment

Choose a reason for hiding this comment

Kerry350 left a comment

Choose a reason for hiding this comment

myasonik commented Jan 16, 2020 • edited Loading

pgayvallet left a comment

Choose a reason for hiding this comment

myasonik commented Jan 18, 2020

myasonik commented Jan 21, 2020

gchaps commented Jan 21, 2020

kibanamachine commented Jan 21, 2020

💚 Build Succeeded

History

myasonik commented Dec 19, 2019 •

edited

Loading

snide commented Jan 7, 2020 •

edited by myasonik

Loading

myasonik commented Jan 8, 2020 •

edited

Loading

myasonik commented Jan 16, 2020 •

edited

Loading